Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.3] Bug 1775323: Enable multiple namespaces sync if catsrc is updated in global ns #1166

Merged
merged 4 commits into from
Dec 4, 2019
Merged

[release-4.3] Bug 1775323: Enable multiple namespaces sync if catsrc is updated in global ns #1166

merged 4 commits into from
Dec 4, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1125

/assign dinhxuanvu

@dinhxuanvu
Enable multiple namespaces sync if catsrc is updated in global ns
a9a97cc 
Currently, if CatalogSource is updated and connection is Ready,
only the namespace where CatalogSource resides gets resynced. Now, a list
of namespaces that contain Subscriptions that use updated CatalogSource
will get resynced instead.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
Add e2e test case for syncSourceState
bd50fd2 
Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
Fix updateInternalCatalog namespace bug
9f85abd 
Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu
Change index func to return list of ns instead
56c7cb8 
Signed-off-by: Vu Dinh <vdinh@redhat.com>
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 3, 2019
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 3, 2019
Merged
5 tasks
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1779313, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1779313: Enable multiple namespaces sync if catsrc is updated in global ns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2019
@dinhxuanvu dinhxuanvu changed the title [release-4.3] Bug 1779313: Enable multiple namespaces sync if catsrc is updated in global ns Bug 1775323 [release-4.3] Bug 1779313: Enable multiple namespaces sync if catsrc is updated in global ns Dec 3, 2019
@dinhxuanvu dinhxuanvu changed the title Bug 1775323 [release-4.3] Bug 1779313: Enable multiple namespaces sync if catsrc is updated in global ns [release-4.3] Bug 1775323: Enable multiple namespaces sync if catsrc is updated in global ns Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 3, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1775323, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[release-4.3] Bug 1775323: Enable multiple namespaces sync if catsrc is updated in global ns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member

/retest

3 similar comments
@dinhxuanvu
Copy link
Member

/retest

@jpeeler
Copy link

jpeeler commented Dec 3, 2019

/retest

@jpeeler
Copy link

jpeeler commented Dec 4, 2019

/retest

@jpeeler
Copy link

jpeeler commented Dec 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpeeler, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7dfd451 into operator-framework:release-4.3 Dec 4, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1775323 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1775323: Enable multiple namespaces sync if catsrc is updated in global ns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dinhxuanvu
Copy link
Member

/cherry-pick release-4.2

@openshift-cherrypick-robot
Copy link
Author

@dinhxuanvu: failed to push cherry-picked changes in GitHub: pushing failed, output: "remote: Not Found\nfatal: repository 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/operator-framework/operator-lifecycle-manager/' not found\n", error: exit status 128

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeeler jpeeler Awaiting requested review from jpeeler

@njhale njhale Awaiting requested review from njhale

Assignees

@jpeeler jpeeler

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @dinhxuanvu @jpeeler @openshift-merge-robot