BUG: Fix CI Unit tests. #1175
BUG: Fix CI Unit tests. #1175
Conversation
openshift-ci-robot
added
the
size/XS
awgreene
force-pushed
the
test
branch
2 times, most recently
from
be510c8 to
5cd3235
Compare
|
/retest |
1 similar comment
|
/retest |
|
I don't think this is the correct fix, at least in all cases. I attempted to run the unit test target locally in a container with networking disabled and it did not work. I suspect that somewhere in CI the mod setting is getting set, which means it'll work in CI, but won't work correctly for local development (but might appear to at first due to modules being downloaded on demand). |
awgreene
force-pushed
the
test
branch
7 times, most recently
from
9c863c5 to
a10d966
Compare
This commit introduces a change which ensures that the GOFLAGS variable is not set when running Makefile commands.
|
This is what changed: openshift/release#6226. They are discouraging plumbing the command flag through all the commands... but we've already done all of that. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.3 |
|
@awgreene: new pull request created: #1196 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Testing a unit test failure