Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.3] Bug 1779995: fix(packageserver): cache packagemanifests #1181

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #1150

/assign njhale

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 9, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1779990, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.3] Bug 1779990: fix(packageserver): cache packagemanifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 9, 2019
@njhale
Copy link
Member

njhale commented Dec 9, 2019

/retest

@njhale njhale changed the title [release-4.3] Bug 1779990: fix(packageserver): cache packagemanifests [release-4.3] Bug 1779995: fix(packageserver): cache packagemanifests Dec 9, 2019
@openshift-ci-robot

This comment has been minimized.

@njhale
Copy link
Member

njhale commented Dec 9, 2019

/bugzilla refresh

@openshift-ci-robot

This comment has been minimized.

@njhale
Copy link
Member

njhale commented Dec 9, 2019

BZ automation is having some trouble RN: https://coreos.slack.com/archives/CEKNRGF25/p1575911986238000

@njhale
Copy link
Member

njhale commented Dec 9, 2019

/retest

@njhale
Copy link
Member

njhale commented Dec 10, 2019

/retest

@ecordell
Copy link
Member

/lgtm

waiting for verification in master

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@shawn-hurley shawn-hurley added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 10, 2019
@shawn-hurley
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2019
@shawn-hurley
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2019
@shawn-hurley
Copy link
Member

/retest

3 similar comments
@njhale
Copy link
Member

njhale commented Dec 10, 2019

/retest

@njhale
Copy link
Member

njhale commented Dec 11, 2019

/retest

@ecordell
Copy link
Member

/retest

@njhale
Copy link
Member

njhale commented Dec 11, 2019

Looks like there are some potentially real unit test flakes, and more concerning, real console e2e tests failing. Investigating now...

/hold
/retest

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
@spadgett
Copy link
Contributor

/retest

@njhale
Copy link
Member

njhale commented Dec 11, 2019

@spadgett and I had a discussion on slack around this -- haven't found a root cause yet.

/retest

@njhale
Copy link
Member

njhale commented Dec 11, 2019

Re-ran the test of another 4.3 PR to see if the failure is disjoint from this patch.

@njhale
Copy link
Member

njhale commented Dec 12, 2019

/retest

@njhale
Copy link
Member

njhale commented Dec 12, 2019

Looks like the other backport failing on the same thing: #1179 (comment)

@njhale
Copy link
Member

njhale commented Dec 12, 2019

/retest

@njhale
Copy link
Member

njhale commented Dec 12, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@njhale: This pull request references Bugzilla bug 1779995, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/retest

@ecordell
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2019
@njhale
Copy link
Member

njhale commented Dec 12, 2019

/retest

1 similar comment
@njhale
Copy link
Member

njhale commented Dec 13, 2019

/retest

@njhale
Copy link
Member

njhale commented Dec 13, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@njhale: This pull request references Bugzilla bug 1779995, which is valid. The bug has been moved to the POST state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/refresh

@njhale
Copy link
Member

njhale commented Dec 13, 2019

/retest

1 similar comment
@ecordell
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit bda7125 into operator-framework:release-4.3 Dec 13, 2019
@openshift-ci-robot
Copy link
Collaborator

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1779995 has been moved to the MODIFIED state.

In response to this:

[release-4.3] Bug 1779995: fix(packageserver): cache packagemanifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

ecordell commented Jan 9, 2020

/cherry-pick release-4.2

@openshift-cherrypick-robot
Copy link
Author

@ecordell: #1181 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	pkg/package-server/provider/registry_test.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging pkg/package-server/provider/registry_test.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Patch failed at 0001 fix(packageserver): cache packagemanifests

In response to this:

/cherry-pick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants