-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor catalog polling to use updateStrategy field #1226
fix: refactor catalog polling to use updateStrategy field #1226
Conversation
/test unit |
Shouldn't we update this doc too? https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/catalog-polling.md |
c2f48e8
to
d75ca3b
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, exdx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/refresh |
/retest |
/test unit |
1 similar comment
/test unit |
/retest |
/test e2e-aws-olm |
Description of the change:
Updates the catalog source spec to change the polling field. Continuation of #1161. Example of new spec:
Motivation for the change:
updateStrategy
is more generic and will be useful when adding additional update sources in the future. There was an attempt to look atunion
types and try to implement the update strategy as a union struct but we did not find that the latest controller-tools supportedunion
types at this time.Reviewer Checklist
/docs