Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor catalog polling to use updateStrategy field #1226

Merged

Conversation

exdx
Copy link
Member

@exdx exdx commented Jan 13, 2020

Description of the change:
Updates the catalog source spec to change the polling field. Continuation of #1161. Example of new spec:

spec:
  displayName: CatalogSource Test
  sourceType: grpc
  image: quay.io/olmtest/catsrc-update-test:test
  updateStrategy:
    registryPoll:
      interval: 2m

Motivation for the change:
updateStrategy is more generic and will be useful when adding additional update sources in the future. There was an attempt to look at union types and try to implement the update strategy as a union struct but we did not find that the latest controller-tools supported union types at this time.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2020
@exdx
Copy link
Member Author

exdx commented Jan 13, 2020

/test unit

@ecordell
Copy link
Member

Shouldn't we update this doc too? https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/catalog-polling.md

@exdx exdx force-pushed the fix/catalog-polling-spec branch from c2f48e8 to d75ca3b Compare January 13, 2020 20:13
@exdx exdx requested a review from dinhxuanvu January 13, 2020 21:14
@exdx
Copy link
Member Author

exdx commented Jan 13, 2020

/retest

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, exdx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@ecordell
Copy link
Member

/refresh

@exdx
Copy link
Member Author

exdx commented Jan 14, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Jan 14, 2020

/test unit

1 similar comment
@exdx
Copy link
Member Author

exdx commented Jan 14, 2020

/test unit

@exdx
Copy link
Member Author

exdx commented Jan 14, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Jan 14, 2020

/test e2e-aws-olm

@openshift-merge-robot openshift-merge-robot merged commit ffb7589 into operator-framework:master Jan 14, 2020
@exdx exdx deleted the fix/catalog-polling-spec branch January 15, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants