Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pyjq and yq from the release documentation prereqs. #1229

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Remove pyjq and yq from the release documentation prereqs. #1229

merged 1 commit into from
Jan 15, 2020

Conversation

benluddy
Copy link
Contributor

The release now uses a vendored copy of yq, and pyjq is unused.

@benluddy
Remove pyjq and yq from the release documentation prereqs.
fe0bf49 
The release now uses a vendored copy of yq, and pyjq is unused.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2020
gallettilance
gallettilance approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@benluddy
Copy link
Contributor Author

/retest

ecordell
ecordell approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, ecordell, gallettilance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@ecordell
Copy link
Member

/retest

2 similar comments
@benluddy
Copy link
Contributor Author

/retest

@benluddy
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@benluddy: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade fe0bf49 link /test e2e-gcp-upgrade
ci/prow/e2e-gcp fe0bf49 link /test e2e-gcp
ci/prow/e2e-aws-console-olm fe0bf49 link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benluddy benluddy merged commit c26a5e2 into operator-framework:master Jan 15, 2020
@benluddy benluddy deleted the release-doc-prereqs branch January 15, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallettilance gallettilance gallettilance approved these changes

@ecordell ecordell ecordell approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@ecordell ecordell

@gallettilance gallettilance

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benluddy @openshift-ci-robot @ecordell @gallettilance