-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependency on github.com/openshift/api #1241
Conversation
Hi @grdryn. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@grdryn Thanks for the PR - could you run |
02455b8
to
194ff26
Compare
@ecordell I've updated that now, thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, grdryn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
194ff26
to
9b81c79
Compare
New changes are detected. LGTM label has been removed. |
@grdryn what changed when you force pushed? I don't see a difference |
@ecordell it was just a rebase because of some conflicts in the generated files ( I'm not familiar enough with the failing e2e tests to know if they're failing because of my changes, are they? |
@grdryn if you could rebase when you get the chance, I'll circle back for a swift review to get this in. |
It looks like the openshift/api project deleted all of their tags, so now the following error is thrown any time we run e.g. a `go mod tidy` in any project that depends on it: ``` go: github.com/openshift/api@v3.9.1-0.20190924102528-32369d4db2ad+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found ``` For this change, all I did was remove the entries in "require" and "replace" in the go.mod, manually added the new "replace" and ran `make vendor`. See openshift/api#456 for more info on the issue.
9b81c79
to
14919df
Compare
@njhale I've rebased & bumped the commit of openshift/api (I don't really know what it should be set to, so I've just used the latest commit on master). |
/retest |
/test unit ^Unit tests seem to work fine for me locally 🤷♂️ |
@grdryn: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test unit |
This was resolved in #1370 |
It looks like the openshift/api project deleted all of their tags, so
now the following error is thrown any time we run e.g. a
go mod tidy
in any project that depends on it:
For this change, all I did was remove the entries in "require" and
"replace" in the go.mod, manually added the new "replace" and ran
go mod tidy
.See openshift/api#456 for more info on the
issue.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs