-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump kube to 1.17 #1362
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anik120 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
k8s.io/component-base v0.0.0 | ||
k8s.io/klog v1.0.0 | ||
k8s.io/kube-aggregator v0.0.0 | ||
k8s.io/kube-openapi v0.0.0-20190918143330-0270cf2f1c1d | ||
k8s.io/kubernetes v1.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please move all k8s modules to native versions: no more v0.0.0
this would be in line with operator-framework/operator-registry#201 and operator-framework/api#17
Also please note that k8s/kubernetes should not be a requirement and is used for locking the versions of the other libraries
Can you please try to remove the import of k8s.io/kubernetes
and move all other imports as k8s.io/api v0.17.3
to have them as k8s 1.17.3
Could you please remove the k8s repos from the replace
directive down in the go.mod, otherwise any change in the require
will be overridden by the replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LouisPlisso thank you for your review. It was a WIP PR, apologies for not editing the title with WIP. PTAL now.
Unfortunately though, we still have to keep the replace
directive, since we're using the rbacauthorizer of k8s.io/kubernetes
, which in turn requires v0.0.0
of all k8s.io
modules.
Thoughts @operator-framework/team-olm ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates kube dependencies to 1.17
/test unit |
/test verify |
@anik120: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description of the change:
Updates kube dependencies to 1.17
Reviewer Checklist
/docs