Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump kube to 1.17 #1362

Closed
wants to merge 1 commit into from

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Mar 10, 2020

Description of the change:
Updates kube dependencies to 1.17

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 10, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anik120
To complete the pull request process, please assign kevinrizza
You can assign the PR to them by writing /assign @kevinrizza in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

go.mod Outdated
Comment on lines 35 to 39
k8s.io/component-base v0.0.0
k8s.io/klog v1.0.0
k8s.io/kube-aggregator v0.0.0
k8s.io/kube-openapi v0.0.0-20190918143330-0270cf2f1c1d
k8s.io/kubernetes v1.16.0
Copy link

@LouisPlisso LouisPlisso Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please move all k8s modules to native versions: no more v0.0.0

this would be in line with operator-framework/operator-registry#201 and operator-framework/api#17

Also please note that k8s/kubernetes should not be a requirement and is used for locking the versions of the other libraries

Can you please try to remove the import of k8s.io/kubernetes and move all other imports as k8s.io/api v0.17.3 to have them as k8s 1.17.3

Could you please remove the k8s repos from the replace directive down in the go.mod, otherwise any change in the require will be overridden by the replace

Copy link
Contributor Author

@anik120 anik120 Mar 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LouisPlisso thank you for your review. It was a WIP PR, apologies for not editing the title with WIP. PTAL now.
Unfortunately though, we still have to keep the replace directive, since we're using the rbacauthorizer of k8s.io/kubernetes, which in turn requires v0.0.0 of all k8s.io modules.

Thoughts @operator-framework/team-olm ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've attempted to remove dependency on k8s.io/kubernetes and import all other k8s.io/kubernetes as v0.17.3 by manually vendoring in k8s.io/kubernetes in #1370. I'll close this PR in favour of #1370 if that idea has sufficient votes.

Updates kube dependencies to 1.17
@anik120 anik120 changed the title chore(deps): bump kube to 1.17.3 chore(deps): bump kube to 1.17 Mar 12, 2020
@anik120
Copy link
Contributor Author

anik120 commented Mar 12, 2020

/test unit

@anik120
Copy link
Contributor Author

anik120 commented Mar 12, 2020

/test verify

@openshift-ci-robot
Copy link
Collaborator

@anik120: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 8d21c4c link /test verify
ci/prow/e2e-aws-olm 8d21c4c link /test e2e-aws-olm
ci/prow/e2e-gcp 8d21c4c link /test e2e-gcp
ci/prow/e2e-gcp-upgrade 8d21c4c link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@njhale
Copy link
Member

njhale commented Mar 19, 2020

@anik120 has this been superseded by #1370?

@anik120
Copy link
Contributor Author

anik120 commented Mar 20, 2020

@njhale yes.

Closing in favor of #1370

@anik120 anik120 closed this Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants