Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end test binary can set up test clusters #1410

Merged
merged 1 commit into from
Apr 2, 2020
Merged

End-to-end test binary can set up test clusters #1410

merged 1 commit into from
Apr 2, 2020

Conversation

benluddy
Copy link
Contributor

This change gives the end-to-end test binary the ability, gated by
build tags, to provision, deprovision, and perform test operation
installation on test clusters.

Without any tags, the default "provisioner" points to an existing
cluster specified by either $KUBECONFIG, $HOME/.kube/config, or
in-cluster service discovery. An alternate Kubernetes-in-Docker (kind)
provisioner is available. The default installer is a no-op, but this
commit also introduces an optional Helm installer, which installs the
OLM chart (now built into the test binary).

Provisioning, installation, and deprovisioning are run as part of the
Ginkgo BeforeSuite/AfterSuite closures.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
awgreene
awgreene reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

deploy/chart/Chart.yaml
@@ -1,3 +1,4 @@
apiVersion: v2
description: A Helm chart for Kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this description verbose enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the original description from 2017. If we decide to include the chart as part of the release (as opposed to only using it for templating internally) then it should definitely be improved, but I don't think it needs to be touched as part of this PR.

test/e2e/e2e_test.go Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@benluddy
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@benluddy
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2020
harishsurf
harishsurf reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@harishsurf harishsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ben for working on this, especially, setting up a base for kind cluster. I have left a few minor nits. Also, I felt it would be helpful if some of the files (helm.go, derived.go,must.go, none.go, etc) had a small description of its intended use.

test/e2e/ctx/ctx.go Show resolved Hide resolved
test/e2e/e2e_test.go Show resolved Hide resolved
test/e2e/installer/helm.go Outdated Show resolved Hide resolved
test/e2e/installer/helm.go Outdated Show resolved Hide resolved
test/e2e/installer/helm.go Outdated Show resolved Hide resolved
x.mk Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2020
@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@njhale
Copy link
Member

njhale commented Mar 31, 2020 •
edited
Loading

/hold

This may seem like a nit, but can we amend the commit message before we merge this?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@ecordell
Copy link
Member

ecordell commented Apr 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@benluddy
Copy link
Contributor Author

benluddy commented Apr 1, 2020

/retest

@ecordell
Copy link
Member

ecordell commented Apr 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@benluddy
test commit please ignore
bc06046 
This change gives the end-to-end test binary the ability, gated by
build tags, to provision, deprovision, and perform test operation
installation on test clusters.

Without any tags, the default "provisioner" points to an existing
cluster specified by either $KUBECONFIG, $HOME/.kube/config, or
in-cluster service discovery. An alternate Kubernetes-in-Docker (kind)
provisioner is available. The default installer is a no-op, but this
commit also introduces an optional Helm installer, which installs the
OLM chart (now built into the test binary).

Provisioning, installation, and deprovisioning are run as part of the
Ginkgo BeforeSuite/AfterSuite closures.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@ecordell
Copy link
Member

ecordell commented Apr 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, benluddy, ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 89e8b5d into operator-framework:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishsurf harishsurf harishsurf left review comments

@awgreene awgreene awgreene left review comments

@njhale njhale njhale left review comments

@ecordell ecordell ecordell left review comments

@anik120 anik120 Awaiting requested review from anik120

@exdx exdx Awaiting requested review from exdx

Assignees

@ecordell ecordell

@awgreene awgreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@benluddy @openshift-bot @ecordell @njhale @openshift-ci-robot @awgreene @harishsurf @openshift-merge-robot