-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1833419: Detect WebhookDescription changes in CSVs #1509
Bug 1833419: Detect WebhookDescription changes in CSVs #1509
Conversation
@awgreene: This pull request references Bugzilla bug 1833419, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8f50e41
to
5646d61
Compare
/bugzilla refresh |
@awgreene: This pull request references Bugzilla bug 1833419, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
438d44d
to
09255b8
Compare
09255b8
to
646a0a4
Compare
Problem: Once a CSV has reached the Succeeded phase, updating WebhookDescriptions in the CSV on cluster does not cause OLM to update existing ValidatingWebhookConfigurations or MutatingWebhookConfigurations on cluster. Solution: Update OLM to calculate if a change to the WebhookDescription has occurred when a CSV is updated and if so update the on cluster resources.
646a0a4
to
23181b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, dinhxuanvu, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@awgreene: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1509. Bugzilla bug 1833419 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Problem:
Once a CSV has reached the Succeeded phase, updating
WebhookDescriptions in the CSV on cluster does not cause OLM to update
existing ValidatingWebhookConfigurations or
MutatingWebhookConfigurations on cluster.
Solution:
Update OLM to calculate if a change to the WebhookDescription has
occurred when a CSV is updated and if so update the on cluster
resources.