Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support priorityclass, poddisruptionbudget, and vpa objects #1577

Merged
merged 1 commit into from
Jul 5, 2020
Merged

feat: support priorityclass, poddisruptionbudget, and vpa objects #1577

merged 1 commit into from
Jul 5, 2020

Conversation

exdx
Copy link
Member

@exdx exdx commented Jun 8, 2020 •
edited
Loading

Description of the change:
Support objects types for aggregated api-servers:

  • PodDisruptionBudgets
  • PriorityClasses
  • VerticalPodAutoscaler

These objects are supported with create/recreate features only as per the epic.

Motivation for the change:

See #1564

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@exdx exdx force-pushed the feat/support-pdbs branch 2 times, most recently from bd41543 to dddd922 Compare June 9, 2020 14:37
@exdx exdx changed the title feat: support priorityclasses and poddisruptionbudgets feat: support priorityclasses, poddisruptionbudgets, and vpa objects Jun 10, 2020
@exdx exdx changed the title feat: support priorityclasses, poddisruptionbudgets, and vpa objects feat: support priorityclass, poddisruptionbudget, and vpa objects Jun 10, 2020
@exdx
Copy link
Member Author

exdx commented Jun 19, 2020

Holding this until the enhancement for managing potentially unsafe operator installations via alerts is approved.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@exdx
Copy link
Member Author

exdx commented Jun 23, 2020

/retest

@exdx
Copy link
Member Author

exdx commented Jun 23, 2020

We are OK going ahead with this merge as-is as we continue to refine the policy around bundle objects in the bad operator actions enhancement.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
kevinrizza
kevinrizza requested changes Jun 25, 2020
View reviewed changes
pkg/lib/operatorlister/lister.go Outdated Show resolved Hide resolved
pkg/lib/ownerutil/util.go Outdated Show resolved Hide resolved
@exdx exdx requested a review from kevinrizza June 25, 2020 17:56
@exdx
feat: support new bundle object types: priorityclass, pdb, and vpa
4aa2684 
objects are now resolved from the bundle by OLM.
@exdx exdx force-pushed the feat/support-pdbs branch from 48a7503 to 4aa2684 Compare June 25, 2020 19:51
@kevinrizza
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@njhale
Copy link
Member

njhale commented Jun 30, 2020

/retest

ecordell
ecordell approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

dinhxuanvu
dinhxuanvu approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell, exdx, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ecordell,kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

23 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ff94842 into operator-framework:master Jul 5, 2020
@ecordell
Copy link
Member

ecordell commented Jul 8, 2020

@jianzhangbjz please review the test cases

@jianzhangbjz
Copy link
Contributor

@kuiwang02 Could you help have a review? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bowenislandsong Bowenislandsong Bowenislandsong left review comments

@jianzhangbjz jianzhangbjz jianzhangbjz left review comments

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@ecordell ecordell ecordell approved these changes

@benluddy benluddy Awaiting requested review from benluddy

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@exdx @kevinrizza @njhale @openshift-bot @openshift-ci-robot @dinhxuanvu @ecordell @jianzhangbjz @Bowenislandsong @openshift-merge-robot