Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1861605: Update manifests to include the bug fix #1720

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Bug 1861605: Update manifests to include the bug fix #1720

merged 1 commit into from
Aug 19, 2020

Conversation

simrandhaliw
Copy link
Contributor

This PR updates manifests to include a bug fix

@simrandhaliw simrandhaliw requested a review from njhale August 10, 2020 19:02
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 10, 2020
@openshift-ci-robot
Copy link
Collaborator

@simrandhaliw: This pull request references Bugzilla bug 1861605, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1861605: Update manifests to include the bug fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

njhale
njhale requested changes Aug 17, 2020
View reviewed changes
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the release manifest generation wasn't completed for v0.16.0, so we're missing its directory and that's leaking into this PR.

We're currently working on out-of-tree release artifacts, so I don't think we should continue to populate these manifests (especially in a bug fix).

deploy/ocp/manifests/0.16.0/0000_50_olm_00-catalogsources.crd.yaml Outdated Show resolved Hide resolved
@simrandhaliw
Bug 1861605: Update manifests to include the bug fix
3c23b77 
This PR updates manifests to include a [bug fix](operator-framework/api#59)
@simrandhaliw simrandhaliw force-pushed the update-manifests-to-include-bug-fix branch from 1030967 to 3c23b77 Compare August 18, 2020 12:14
@simrandhaliw
Copy link
Contributor Author

/test unit

1 similar comment
@simrandhaliw
Copy link
Contributor Author

/test unit

@simrandhaliw
Copy link
Contributor Author

/test e2e-gcp

2 similar comments
@simrandhaliw
Copy link
Contributor Author

/test e2e-gcp

@simrandhaliw
Copy link
Contributor Author

/test e2e-gcp

@benluddy
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, njhale, simrandhaliw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Member

njhale commented Aug 19, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@awgreene
Copy link
Member

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 6e748e0 into operator-framework:master Aug 19, 2020
@openshift-ci-robot
Copy link
Collaborator

@simrandhaliw: All pull requests linked via external trackers have merged: operator-framework/operator-lifecycle-manager#1720, operator-framework/operator-lifecycle-manager#1713, operator-framework/api#59. Bugzilla bug 1861605 has been moved to the MODIFIED state.

In response to this:

Bug 1861605: Update manifests to include the bug fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njhale njhale njhale approved these changes

@Bowenislandsong Bowenislandsong Awaiting requested review from Bowenislandsong

@kevinrizza kevinrizza Awaiting requested review from kevinrizza

Assignees

@njhale njhale

@awgreene awgreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@simrandhaliw @openshift-ci-robot @benluddy @njhale @awgreene @openshift-merge-robot