-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set labels for the operator Deployment created via the ClusterServiceVersion #2054
Set labels for the operator Deployment created via the ClusterServiceVersion #2054
Conversation
Hi @dmvolod. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…Version Signed-off-by: Dmitry Volodin <dmvolod@gmail.com>
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmvolod, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
@kevinrizza , @ecordell is there any chance to backport this feature to one of the release 4.6, 4.7, 4.8 or 4.9 or backports are only for bugs? |
@dmvolod for openshift backports are exclusively for bugs unfortuntely |
Has this feature been rolled out to any of the 4.10 OpenShift releases? I followed the instructions and added the labels to the CSV but when it gets applied on the cluster, I don't see the labels getting persisted.
Is this feature released yet? Thank you |
Description of the change:
With this changes is possible to set custom labels for Deployment in addition to the system labels set by the OLM. This labels should be present in the
labels
fields of thedeployments
section.Motivation for the change:
Would like the ability to set labels for the operator Deployment created via the ClusterServiceVersion.
Only owner labels are set by OLM, and the operator Deployment is limited to setting the DeploymentSpec, with no ability to set any metadata such as labels.
Custom operator deployment labels is very desirable feature, for example when we need to lookup operator deployment from the operator code itself and the name of this deployment could be change potentially and we don't want to change the logic every update. Only custom CSV based labels could help in this case.
Reviewer Checklist
/docs
Closes #1522