Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused registry client fake and remove go:generate. #2783

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented May 24, 2022

This fake is unused and was removed in an earlier patch (#2649), but
apparently there was another corresponding go:generate comment that wasn't removed.

This fake is unused and was removed in an earlier patch, but
apparently there was another corresponding go:generate comment that
wasn't removed.

Signed-off-by: Ben Luddy <bluddy@redhat.com>
@openshift-ci openshift-ci bot requested review from exdx and timflannagan May 24, 2022 17:02
@openshift-ci
Copy link

openshift-ci bot commented May 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
@oceanc80
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit cbb6c3d into operator-framework:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants