-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation/uninstallation docs #2784
Conversation
Changes "exmaple" to "example" Signed-off-by: Noah Sapse <nsapse@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
- Closes operator-framework#2662 - Updates installation document to include `operator-sdk olm install` as an install method - Updates installation document to include `operator-sdk olm uninstall` as an uninstall method Signed-off-by: Noah Sapse <nsapse@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: exdx, nsapse, tylerslaton The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix spelling error Changes "exmaple" to "example" Signed-off-by: Noah Sapse <nsapse@gmail.com> * Updates Installation/Uninstallation Documents - Closes operator-framework#2662 - Updates installation document to include `operator-sdk olm install` as an install method - Updates installation document to include `operator-sdk olm uninstall` as an uninstall method Signed-off-by: Noah Sapse <nsapse@gmail.com>
* Fix spelling error Changes "exmaple" to "example" Signed-off-by: Noah Sapse <nsapse@gmail.com> * Updates Installation/Uninstallation Documents - Closes operator-framework#2662 - Updates installation document to include `operator-sdk olm install` as an install method - Updates installation document to include `operator-sdk olm uninstall` as an uninstall method Signed-off-by: Noah Sapse <nsapse@gmail.com>
* Fix spelling error Changes "exmaple" to "example" Signed-off-by: Noah Sapse <nsapse@gmail.com> * Updates Installation/Uninstallation Documents - Closes operator-framework#2662 - Updates installation document to include `operator-sdk olm install` as an install method - Updates installation document to include `operator-sdk olm uninstall` as an uninstall method Signed-off-by: Noah Sapse <nsapse@gmail.com>
Description of the change:
Updates installation document to mention
operator-sdk olm [install/uninstall]
. Separate commit fixes small unrelated spelling error found in documents.Motivation for the change:
Users have repeatedly asked for an
uninstall.sh
script as a means of uninstalling OLM. We should point users in the direction of currently existing and actively maintained functionality for that purpose.Reviewer Checklist
/doc
[FLAKE]
are truly flaky[FLAKE]
tag are no longer flaky