Don't generate kubeclient at runtime in testing #2790
Conversation
nsapse
force-pushed
the
2570_kubeclient
branch
2 times, most recently
from
38595e6
to
185c4e5
Compare
test/e2e/operator_groups_e2e_test.go
Outdated
| ) | ||
|
|
||
| var _ = Describe("Operator Group", func() { | ||
|
|
There was a problem hiding this comment.
Nit: remove this newline, applies everywhere.
| BeforeEach(func() { | ||
| c = ctx.Ctx().KubeClient() | ||
| crc = ctx.Ctx().OperatorClient() | ||
| }) |
There was a problem hiding this comment.
Nit: Add a newline, applies everywhere.
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, exdx, nsapse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Looks really good, nice job. Didn't intend for this to merge right away so I put a hold on it -- let's address the whitespacing concerns and rebase off latest and then I will re-lgtm and drop the hold |
|
/hold cancel |
openshift-ci
bot
added
lgtm
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
New changes are detected. LGTM label has been removed. |
- Updates tests to use common Kube and Runtime clients generated at startup time rather than having them re-generated in each test at runtime. - Closes operator-framework#2570 Signed-off-by: Noah Sapse <nsapse@gmail.com>
|
Good to merge then? |
startup time rather than having them re-generated in each test at
runtime.
Signed-off-by: Noah Sapse nsapse@gmail.com
Description of the change:
Motivation for the change:
Reviewer Checklist
/doc[FLAKE]are truly flaky[FLAKE]tag are no longer flaky