Unpack job security updates #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
perdasilva
force-pushed
the
unpack_job_security_updates_2
branch
2 times, most recently
from
0442f78
to
0275c0d
Compare
perdasilva
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
perdasilva
changed the title
perdasilva
force-pushed
the
unpack_job_security_updates_2
branch
from
0275c0d
to
b349543
Compare
| "", | ||
| }, | ||
| Verbs: []string{ | ||
| "get", "update", |
There was a problem hiding this comment.
Do we need to create the configmap to unpack the bundles?
Assuming that we are testing it on the ci and all is passing that seems that we do not need it.
Then, the changes shows fine for me
/approved
/lgtm
camilamacedo86
approved these changes
Jun 22, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
11 tasks
perdasilva
added a commit
to perdasilva/operator-lifecycle-manager
that referenced
this pull request
Jun 23, 2022
This reverts commit e568cde.
perdasilva
added a commit
to perdasilva/operator-lifecycle-manager
that referenced
this pull request
Jun 23, 2022
This reverts commit e568cde. Signed-off-by: perdasilva <perdasilva@redhat.com>
perdasilva
added a commit
that referenced
this pull request
Jun 23, 2022
* Revert "Unpack job security updates (#2805)" This reverts commit e568cde. Signed-off-by: perdasilva <perdasilva@redhat.com> * Revert "Update unpack job pod security (#2793)" This reverts commit eedad28. Signed-off-by: perdasilva <perdasilva@redhat.com> * Revert "Update CatalogSource Pod security context (#2782)" This reverts commit 99b51e7. Signed-off-by: perdasilva <perdasilva@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the unpacker job role policy creating to its own method to make downstream patching easier and less dangerous