-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use $BUILDPLATFORM image for goreleaser #2896
Don't use $BUILDPLATFORM image for goreleaser #2896
Conversation
Hi @StopMotionCuber. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b0e6e72
to
23bfae2
Compare
Any ETA on this? This is blocking us from using OLM on ARM. |
Can you please review and merge this? olm doesn't work on an arm cluster without this change. |
/ok-to-test |
23bfae2
to
f1199c2
Compare
Signed-off-by: Ruben Simons <r.simons@fz-juelich.de>
f1199c2
to
b6e9554
Compare
Have rebased the branch and added a sign-off to make it compliant with the DCO policy in the repo, would like to see it get merged |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, dmesser, StopMotionCuber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for pulling this in! @dmesser , do you know when this might be released? We're excited to start running OLM in ARM. :) |
Can we get a minor version release with this fix? |
Released v0.24.0, which contains this commit. |
Description of the change: Removes the
--platform=$BUILDPLATFORM
argumentMotivation for the change: When specifying the platform as $BUILDPLATFORM, amd64 binaries are taken. This leads to the image not being multi-arch, but still having an amd64 busybox binary.
The util init container of jobs are failing with an
exec /bin/cp: exec format error
.Architectural changes: None
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issueFurther remarks: I already opened #2890 to increase multi-arch/arm64 compatibility. In case wanted, I can also incorporate this change into that PR