Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use $BUILDPLATFORM image for goreleaser #2896

Conversation

StopMotionCuber
Copy link
Contributor

Description of the change: Removes the --platform=$BUILDPLATFORM argument

Motivation for the change: When specifying the platform as $BUILDPLATFORM, amd64 binaries are taken. This leads to the image not being multi-arch, but still having an amd64 busybox binary.
The util init container of jobs are failing with an exec /bin/cp: exec format error.

Architectural changes: None

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Further remarks: I already opened #2890 to increase multi-arch/arm64 compatibility. In case wanted, I can also incorporate this change into that PR

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 16, 2022

Hi @StopMotionCuber. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@risaraf
Copy link

risaraf commented Jan 18, 2023

Any ETA on this? This is blocking us from using OLM on ARM.

@vihangm
Copy link

vihangm commented Jan 26, 2023

Can you please review and merge this? olm doesn't work on an arm cluster without this change.

@dmesser
Copy link
Contributor

dmesser commented Jan 27, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2023
Signed-off-by: Ruben Simons <r.simons@fz-juelich.de>
@StopMotionCuber
Copy link
Contributor Author

Have rebased the branch and added a sign-off to make it compliant with the DCO policy in the repo, would like to see it get merged

@dmesser dmesser self-requested a review January 27, 2023 13:08
@dmesser dmesser added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 27, 2023
@awgreene
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dmesser, StopMotionCuber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e29776d into operator-framework:master Jan 27, 2023
@StopMotionCuber StopMotionCuber deleted the multiarch_busybox branch January 27, 2023 13:19
@aimichelle
Copy link
Contributor

Thanks for pulling this in! @dmesser , do you know when this might be released? We're excited to start running OLM in ARM. :)

@risaraf
Copy link

risaraf commented Jan 30, 2023

Can we get a minor version release with this fix?

@awgreene
Copy link
Member

awgreene commented Mar 13, 2023

Released v0.24.0, which contains this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants