OCPBUGS-5523: Catalog, fatal error: concurrent map read and map write

[dtfranz]

Protected subscriptionSyncCounters access to prevent concurrent map writes

Description of the change:

The metrics pkg uses a shared map var which is not protected from concurrent read/write access. This PR adds a mutex to lock and unlock before and after each map access instance.

Motivation for the change:

OCPBUGS-5523

[openshift-ci-robot]

@dtfranz: This pull request references Jira Issue OCPBUGS-5523, which is invalid:

• expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Protected subscriptionSyncCounters access to prevent concurrent map writes

Description of the change:

The metrics pkg uses a shared map var which is not protected from concurrent read/write access. This PR adds a mutex to lock and unlock before and after each map access instance.

Motivation for the change:

OCPBUGS-5523

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtfranz]

/jira refresh

[openshift-ci-robot]

@dtfranz: This pull request references Jira Issue OCPBUGS-5523, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[awgreene]

Seems reasonable to me, could we squash the commits? It'll make it easier for downstreaming.

[tmshort]

/lgtm

[awgreene]

@dtfranz this needs a rebase.

[tmshort]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dtfranz, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awgreene]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dtfranz: All pull requests linked via external trackers have merged:

• operator-framework/operator-lifecycle-manager#2913

Jira Issue OCPBUGS-5523 has been moved to the MODIFIED state.

In response to this:

Protected subscriptionSyncCounters access to prevent concurrent map writes

Description of the change:

The metrics pkg uses a shared map var which is not protected from concurrent read/write access. This PR adds a mutex to lock and unlock before and after each map access instance.

Motivation for the change:

OCPBUGS-5523

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.