Registry Pod Controller Flag #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
dtfranz
force-pushed
the
registry-pod-owner-controller
branch
2 times, most recently
from
8c21c3f
to
d0d3604
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
dtfranz
force-pushed
the
registry-pod-owner-controller
branch
from
d0d3604
to
8088d5d
Compare
Sets the marketplace pod's ownerreference to have `controller: true` to remove need for forceful node drain. Signed-off-by: Daniel Franz <dfranz@redhat.com>
awgreene
force-pushed
the
registry-pod-owner-controller
branch
from
8088d5d
to
c40f70c
Compare
|
/approve |
openshift-ci
bot
added
the
approved
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, awgreene, dtfranz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the controller flag on the registry pod owner references to true in an attempt to remove the need for forceful shutdown when draining nodes.