-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates github.com/operator-framework/api #2954
Updates github.com/operator-framework/api #2954
Conversation
Skipping CI for Draft Pull Request. |
1d04848
to
106751d
Compare
e85b3cd
to
0ce77b3
Compare
CI is red because packageserver fails with the following error (not visible in CI logs):
Trying to fix it here: operator-framework/api#168 UPD: fixed. |
531d09e
to
670804c
Compare
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to see another review (with the /lgtm)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, m1kola, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Description of the change:
Updates OLM to use a new release of
github.com/operator-framework/api
which includes several changes which are prerequisites for the following changes:InstallPlan
s when bundle unpack fails #2942 requires new condition types.BundleLookupFailed
defined in OLM to the one defined in the.../api
package #2959 which also requires a constant defined in the api package so we can switch to using it instead of defining it in the OLM codebase.Motivation for the change:
Solving prerequisites for other changes.
Architectural changes:
Updating dependencies
Testing remarks:
Refactoring. Existing tests should provide coverage.
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue