Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cpb to be statically compiled / exempt from FIPS compliance #3001

Closed

Conversation

awgreene
Copy link
Member

To be FIPS compliant, all binaries shipped in OCP must be dynamically linked against openssl unless they are specifically exempted (e.g. they do not perform any cryptography). The golang builder images made available for CI by ART will enforce this requirement (overriding any attempt to statically link) unless the binary is identified in this environment variable.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@awgreene
Copy link
Member Author

/retest

@awgreene awgreene marked this pull request as ready for review July 20, 2023 14:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2023
@openshift-ci openshift-ci bot requested review from joelanford and njhale July 20, 2023 14:22
@awgreene
Copy link
Member Author

/retest

1 similar comment
@awgreene
Copy link
Member Author

/retest

To be FIPS compliant, all binaries shipped in OCP must be dynamically
linked against openssl unless they are specifically exempted
(e.g. they do not perform any cryptography). The golang builder images
made available for CI by ART will enforce this requirement
(overriding any attempt to statically link) unless the binary is
identified in this environment variable.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
@awgreene
Copy link
Member Author

awgreene commented Aug 7, 2023

/retest

1 similar comment
@awgreene
Copy link
Member Author

/retest

Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@perdasilva
Copy link
Collaborator

@awgreene what's up with CI here?

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awgreene
Copy link
Member Author

/retest

1 similar comment
@awgreene
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

@awgreene: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-console-olm a2f0634 link true /test e2e-aws-console-olm
ci/prow/e2e-aws-olm a2f0634 link true /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ncdc
Copy link
Member

ncdc commented Oct 31, 2023

@awgreene would it be ok to close this since it's OpenShift-specific, and make the change in the openshift fork?

@perdasilva
Copy link
Collaborator

closing PR as stale. Please re-open if it's still important.

@perdasilva perdasilva closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants