Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tmshort to reviewers #3008

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Add tmshort to reviewers #3008

merged 1 commit into from
Aug 10, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 8, 2023 •
edited
Loading

Testing remarks:

Reviewer Checklist

  • Code is properly formatted

@tmshort
Copy link
Contributor Author

tmshort commented Aug 10, 2023

/retest

grokspawn
grokspawn reviewed Aug 10, 2023
View reviewed changes
OWNERS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: please also list yourself as an approver if you are comfortable with it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... I wasn't sure if it was up to me! :)

@tmshort
Add tmshort to reviewers
dd3fe76 
Signed-off-by: Todd Short <todd.short@me.com>
@awgreene
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@tmshort
Copy link
Contributor Author

tmshort commented Aug 10, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit ad4ac77 into operator-framework:master Aug 10, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokspawn grokspawn grokspawn approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@awgreene awgreene

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmshort @awgreene @grokspawn @openshift-merge-robot