Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller/registry: implement content extraction for catalog sources #3029

Conversation

stevekuznetsov
Copy link
Member

go.mod: update the api dependency

Signed-off-by: Steve Kuznetsov skuznets@redhat.com


controller/registry: implement content extraction for catalog sources

Signed-off-by: Steve Kuznetsov skuznets@redhat.com


Implements #3019

@stevekuznetsov stevekuznetsov force-pushed the skuznets/extract-fbc branch 2 times, most recently from 1c46464 to 0b67234 Compare September 7, 2023 19:38
@stevekuznetsov stevekuznetsov force-pushed the skuznets/extract-fbc branch 4 times, most recently from 24a7bb6 to be2e37c Compare September 8, 2023 16:05
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2023
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/extract-fbc branch 2 times, most recently from 1745498 to 956d12b Compare September 8, 2023 18:06
@stevekuznetsov
Copy link
Member Author

@joelanford made the changes you suggested. I've used this approach often in the past and found it useful, but only with statically-compiled binaries under my own control. If anything in sh or cp is dynamically linked, this won't work and we will be needing to write a Go program. Not hard, but just something to keep in mind.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@@ -38,7 +38,7 @@ var (

communityOperators = flag.String(
"communityOperators",
"quay.io/operator-framework/upstream-community-operators@sha256:098457dc5e0b6ca9599bd0e7a67809f8eca397907ca4d93597380511db478fec",
"quay.io/operatorhubio/catalog:latest",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelanford unfortunately the specific SHAs for this image are not kept around for very long, as there are no long-lived tags. We will have to suffice with :latest, which might break tests if they are asserting on specifics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for now. It'd be nice if we did the thing we are now doing in catalogd and operator-controller where we have all of our test artifacts actually come out of the repo.

Definitely not a blocker for this though, IMO.

@joelanford
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit ed03be3 into operator-framework:master Sep 12, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants