Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ClusterRoles created by OperatorGroups #3035

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Rename ClusterRoles created by OperatorGroups #3035

merged 2 commits into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. Rename ClusterRoles created by OperatorGroups 

    When an OperatorGroup creates a ClusterRole, it's based directly on the
OG name with a suffix, this causes two issues:
1. same-named OGs in different namespaces overwrite each others CRs
2. there are some very important CRs that could be overwritten by OG

Tests added.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Todd Short <todd.short@me.com>
    @tmshort
    Per Goncalves da Silva authored and tmshort committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    35f8bca View commit details
    Browse the repository at this point in the history

  2. fixup! Rename ClusterRoles created by OperatorGroups 

    Signed-off-by: Todd Short <todd.short@me.com>
    @tmshort
    tmshort committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    94f840b View commit details
    Browse the repository at this point in the history