-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slash command access to make unit #3186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change makes merge queue and other events to skip unit tests.
@bentito could you please double check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm approving, but if you could squash into one commit - that would be great.
This should allow PR comments of the form: `/retest unit` to trigger `make unit` Signed-off-by: btofel <btofel@redhat.com>
39d866f
to
3bbf6a0
Compare
e2e (3) seems to fail on a "Subscription when unpacking bundle with bundle which OLM will fail to unpack [It] should report deprecated status when catalog is updated to deprecate an installed bundle"? Seems unrelated to this PR. Merging again as first check on whether this is a flaky e2e test or something that needs fixing to unblock merges. |
Description of the change:
This should allow PR comments of the form:
/retest unit
to triggermake unit
Motivation for the change:
Prow offers PR comments to trigger fine-grained retest capabilities for tests. This trials adding this capability for the unit test target.
Architectural changes:
None
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue