Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Makefile refactor #3212

Closed

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
Updates the Makefile to be more developer friendly by:

  1. adding help and help-extended targets that make it easy for the developer to know what to do
  2. adding bingo to manage some of the dependencies such as setup-envtest, kind, golangci-lint, etc.
  3. adding targets for creating and nuking an olmv0 kind cluster

Now as a developer it should be easy to:

  1. create a dev cluster with make kind-cluster
  2. deploy to the cluster your kubectl points to make deploy
  3. run e2e tests with make e2e

Motivation for the change:
This is part of a bigger effort to help make olm v0 more maintainable

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Per Goncalves da Silva added 3 commits April 26, 2024 11:54
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva changed the title Makefile refactor [WIP] Makefile refactor Apr 26, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
# setup-envtest on *nix uses XDG_DATA_HOME, falling back to HOME, as the default storage directory. Some CI setups
# don't have XDG_DATA_HOME set; in those cases, we set it here so setup-envtest functions correctly. This shouldn't
# affect developers.
export XDG_DATA_HOME ?= /tmp/.local/share
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joelanford
Copy link
Member

Any chance you can account for this issue while you're at it? #3215

@perdasilva
Copy link
Collaborator Author

Any chance you can account for this issue while you're at it? #3215

Will do. Closing this for now while I finish the other one. This one will need to be rebased and reworked anyway...=S

@perdasilva perdasilva closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants