Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up: remove minikube #3220

Merged
merged 1 commit into from
May 7, 2024
Merged

clean-up: remove minikube #3220

merged 1 commit into from
May 7, 2024

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
Removes minikube and its mentions from the project

Motivation for the change:
Lack of use

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

kevinrizza
kevinrizza previously approved these changes May 6, 2024
View reviewed changes
@kevinrizza kevinrizza added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
remove minikube
2ffd965 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva enabled auto-merge May 7, 2024 06:30
@perdasilva perdasilva disabled auto-merge May 7, 2024 06:40
@perdasilva perdasilva merged commit 66f8571 into operator-framework:master May 7, 2024
12 checks passed
@perdasilva perdasilva deleted the cleanup/minikube branch May 7, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrizza kevinrizza kevinrizza left review comments

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perdasilva @kevinrizza