Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) prevent hash key collision while generating bundle unpacking job name #3332

Closed
wants to merge 1 commit into from

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Jun 27, 2024

No description provided.

@anik120 anik120 force-pushed the unpacking-name branch 2 times, most recently from bd83798 to da2b961 Compare June 28, 2024 19:24
@anik120 anik120 changed the title bundle unpacking: simplify unpack job name generation (fix) prevent hash key collision while generating bundle unpacking job name Jun 28, 2024
…b name

Signed-off-by: Anik Bhattacharjee <anbhatta@redhat.com>
@anik120
Copy link
Contributor Author

anik120 commented Jun 28, 2024

/hold

need more clarification to provide justification for the modifications being done in this PR.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2024
@tmshort
Copy link
Contributor

tmshort commented Jul 1, 2024

The likelyhood of a cache collision with sha256 is quite low. Looking at the issues in question, this might be a caching problem rather than a collision problem. This will not resolve a caching problem.

@anik120 anik120 closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants