Remove OgSourceProvider #3360
Merged
Remove OgSourceProvider #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
anik120
force-pushed
the
remove-og-source-provider
branch
from
413e326
to
9709866
Compare
Merged
11 tasks
[2788](operator-framework#2788) introduced the `OgSourceProvider` that allows for the exclusion of Catalogs in the global namespace. This `OgSourceProvider` was used by the resolver as the `SourceProvider` implementation. [3349](operator-framework#3349) modified the resolver, to list the CatalogSources in the cluster by itself on the basis of the annotation in the `OperatorGroup` in the resolving namespace, so that that information can be passed to the `RegistrySourceProvider`, which now list the CatalogSources using a client instead of reaching out to the registry-server cache. This PR removes the `OgSourceProvider`, since the feature is now being directly implemented in the resolver, and the `OgSourceProvider` implementation has become redundant. Note that the feature parity is still maintained, as attested by the successful execution of [these tests](https://github.com/operator-framework/operator-lifecycle-manager/blob/master/test/e2e/catalog_exclusion_test.go) introduced in 2788.
anik120
force-pushed
the
remove-og-source-provider
branch
from
9709866
to
f6b4198
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Merged
via the queue into
operator-framework:master
with commit Sep 12, 2024
183a7f2
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
2788 introduced the
OgSourceProviderthat allows for the exclusion of Catalogs in the global namespace. This
OgSourceProviderwas used by the resolver as the
SourceProviderimplementation.3349 modified the resolver, to list the CatalogSources
in the cluster by itself on the basis of the annotation in the
OperatorGroupin the resolving namespace, so that that information can be passed to the
RegistrySourceProvider,which now list the CatalogSources using a client instead of reaching out to the
registry-server cache.
This PR removes the
OgSourceProvider, since the feature is now being directly implementedin the resolver, and the
OgSourceProviderimplementation has become redundant.Note that the feature parity is still maintained, as attested by the successful execution
of these tests introduced in 2788.
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue