Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab CI Fix #341

Merged
merged 1 commit into from
May 3, 2018
Merged

Conversation

alecmerdler
Copy link
Member

Description

Use an environment variable instead of hardcoding the hostname.

@alecmerdler alecmerdler added the kind/feature Categorizes issue or PR as related to a new feature. label May 3, 2018
@alecmerdler alecmerdler requested a review from ecordell May 3, 2018 14:36
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecmerdler alecmerdler merged commit 5692d20 into operator-framework:master May 3, 2018
@alecmerdler alecmerdler deleted the teamui-host-var branch May 3, 2018 15:20
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants