Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): commit vendored dependencies #352

Merged
merged 3 commits into from
May 16, 2018

Conversation

ecordell
Copy link
Member

People without access to tectonic-operators can't vendor and build from source. This adds our vendored dependences into the git repo as a temporary workaround.

Longer term the dependency on operator-client will be removed complete, but that will take some time because of our heavy reliance on it for mocks in our test suite.

Fixes #350

@ecordell ecordell requested review from ericavonb and alecmerdler May 15, 2018 20:23
by people without access to tectonic-operators
DashboardURL: a.dashboardURL, // TODO make specific to created resource
},

//TODO: implement exists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this done in my branch.

@ecordell ecordell merged commit 68ffb88 into operator-framework:master May 16, 2018
@ecordell ecordell deleted the vendor-deps branch May 21, 2018 14:28
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
chore(deps): commit vendored dependencies
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
chore(deps): commit vendored dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants