Resolve Install Plan before Requiring Approval #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
commented
Jun 7, 2018
| @@ -54,7 +54,6 @@ type InstallPlanConditionType string | |||
|
|
|||
| const ( | |||
| InstallPlanResolved InstallPlanConditionType = "Resolved" | |||
| InstallPlanApproved InstallPlanConditionType = "Approved" | |||
There was a problem hiding this comment.
Unused, should be determined from spec.approved.
|
The e2e tests were failing because of |
alecmerdler
force-pushed
the
ALM-623
branch
2 times, most recently
from
9daa86c to
ee46f52
Compare
alecmerdler
commented
Jun 7, 2018
test/e2e/alm_e2e_test.go
Outdated
| @@ -132,21 +132,22 @@ func TestCreateInstallPlanManualApproval(t *testing.T) { | |||
| if step.Resource.Kind == "CustomResourceDefinition" { | |||
| _, err := c.GetCustomResourceDefinition(step.Resource.Name) | |||
|
|
|||
| require.NoError(t, err) | |||
| require.Error(t, err) | |||
| vaultResourcesPresent = vaultResourcesPresent + 1 | |||
There was a problem hiding this comment.
@ecordell This fails because our CI target cluster always has all the CRDs. Should we just disable this check?
|
@alecmerdler For the e2e tests, we want them to be aware of the approval state:
|
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
Resolve Install Plan before Requiring Approval
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Resolve Install Plan before Requiring Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes regression introduced which prevented
status.planfrom being filled before a manual install plan is approved. Also updates docs to include theRequiresApprovalphase.Addresses https://jira.coreos.com/browse/ALM-623