Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(servicebroker): add main_test.go to servicebroker cmd #372

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Jun 14, 2018

this will get build by our coverage-enabled builds for testing.

Previously this wasn't building servicebroker with coverage (make build-coverage) because coverage builds use go test which omits packages with no test files. This is the pattern we use for the other commands that let us collect coverage from e2e tests.

this will get build by our coverage-enabled builds for testing
@ecordell ecordell requested a review from alecmerdler June 14, 2018 13:24
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit a740eed into operator-framework:master Jun 14, 2018
@ecordell ecordell deleted the fix-coveragebuild branch July 3, 2018 14:14
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
…uild

fix(servicebroker): add main_test.go to servicebroker cmd
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…uild

fix(servicebroker): add main_test.go to servicebroker cmd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants