Add CatalogSource Namespace to Subscription Objects #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecmerdler
commented
Jul 11, 2018
| // Operator represents a Kubernetes operator that executes InstallPlans by | ||
| // resolving dependencies in a catalog. | ||
| type Operator struct { | ||
| *queueinformer.Operator | ||
| client versioned.Interface | ||
| namespace string | ||
| sources map[string]registry.Source | ||
| sources map[sourceKey]registry.Source |
There was a problem hiding this comment.
Use complex struct which contains both name and namespace as map key (see https://play.golang.org/p/ngwKvwPggu5).
|
Why don't we make this backwards compatible by saying |
|
@ecordell That doesn't help the UI (or non-admin users) find the |
alecmerdler
force-pushed
the
ALM-639
branch
2 times, most recently
from
becf985 to
5a1140a
Compare
|
@ecordell Tests are passing, made it backwards compatible. |
ecordell
requested changes
Jul 13, 2018
| @@ -270,14 +275,14 @@ func (o *Operator) ResolvePlan(plan *v1alpha1.InstallPlan) error { | |||
| var notFoundErr error | |||
| for sourceName, source := range o.sources { | |||
| if notFoundErr != nil { | ||
| continue | ||
| } | ||
|
|
||
| // Look up the CatalogSource. | ||
| catsrc, err := o.client.CatalogsourceV1alpha1().CatalogSources(o.namespace).Get(sourceName, metav1.GetOptions{}) | ||
| catsrc, err := o.client.CatalogsourceV1alpha1().CatalogSources(o.namespace).Get(sourceName.name, metav1.GetOptions{}) |
There was a problem hiding this comment.
should be CatalogSources(sourceName.namespace) just in case?
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
Add CatalogSource Namespace to Subscription Objects
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Add CatalogSource Namespace to Subscription Objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes it possible to find the contents of a
CatalogSource-v1without needing permission to fetch in all namespaces.Fixes https://jira.coreos.com/browse/ALM-639