Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid minishift start option in build_local_shift.sh #392

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

jsm84
Copy link
Contributor

@jsm84 jsm84 commented Jul 24, 2018

This is necessary for using OLM with recent versions of Minishift, as the minishift start command fails with an invalid option for --service-catalog.

@jsm84 jsm84 changed the title Fix invalid minishift start option in install_local_shift.sh Fix invalid minishift start option in build_local_shift.sh Jul 24, 2018
@robszumski robszumski requested a review from jzelinskie July 24, 2018 21:27
@ecordell
Copy link
Member

Thanks @jsm84! Had a problem with the CI cluster but as soon as we get that working I'll merge

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit afba6b8 into operator-framework:master Jul 25, 2018
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
Fix invalid `minishift start` option in build_local_shift.sh
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Fix invalid `minishift start` option in build_local_shift.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants