-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update k8s libs to 1.11 versions #398
Conversation
ecordell
commented
Jul 27, 2018
•
edited
Loading
edited
0988c0e
to
1567974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I definitely may have missed something amongst the 900 files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
15b4a1f
to
85c7a86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I definitely may have missed something amongst the 900 files
serialization. In this case, changing to *json.RawMessage fixes the issue
- remove -v1 suffix from ClusterServiceVersion - makes use of `subresources` for defining statuses - small fixes to schema - re-runs codegen for 1.11
- transitionClusterServiceVersion now returns a new object - helpers still pass around a mutable copy - transition only ever updates the status object directly, not the CSV - switched to structured logging fields where appropriate
- remove -v1 suffix from InstallPlan - makes use of `subresources` for defining statuses - small fixes to schema - re-runs codegen for 1.11
- transitioInstallPlan now returns a new object - helpers still pass around a mutable copy - transition only ever updates the status object directly, not the object - switched to structured logging fields where appropriate - updated CRDs to use additionalPrinterColumns and categories
- remove -v1 suffix from ClusterServiceVersion - makes use of `subresources` for defining statuses - small fixes to schema - re-runs codegen for 1.11
- transition only ever updates the status object directly, not the object - switched to structured logging fields where appropriate - store the received object from the api instead of the sent object
- remove -v1 suffix from CatalogSource - makes use of `subresources` for defining statuses - small fixes to schema - re-runs codegen for 1.11
78fe59a
to
bbed1c9
Compare
the newer versions of kubernetes-codegen didn't like the way we had organized our apis (each type had its own group, but the actual api calls all went to apps.coreos.com) this updates the apis to organize around groups/versions instead of types/versions. this had fairly wide-reaching effects but ultimately, the codebase is much simpler for this change.
(0.22.2 is failing, so disabling the test until we get a version that's fixed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be worried about cleaning up leftover resources in these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Though I may have missed something
chore(deps): update k8s libs to 1.11 versions
chore(deps): update k8s libs to 1.11 versions