Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update k8s libs to 1.11 versions #398

Merged
merged 18 commits into from
Aug 2, 2018

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Jul 27, 2018

$ kubectl -n local get olm
 NAME                                 CSV                    SOURCE         APPROVAL    APPROVED
 install-vault-operator.0.1.9-hdfjf   vault-operator.0.1.9   tectonic-ocs   Automatic   false
 
 NAME      PACKAGE   SOURCE         CHANNEL
 vault     vault     tectonic-ocs   alpha
 
 NAME                  NAME                           TYPE       PUBLISHER      AGE
 tectonic-ocs          Tectonic Open Cloud Services   internal   CoreOS, Inc.   5m
 upstream-components   OLM Upstream Components        internal   CoreOS, Inc.   5m
 
 NAME                   DISPLAY   VERSION   REPLACES               PHASE
 etcdoperator.v0.9.2    etcd      0.9.2     etcdoperator.v0.9.0    Succeeded
 vault-operator.0.1.9   Vault     0.1.9     vault-operator.0.1.5   Succeeded

@ecordell ecordell requested review from njhale and alecmerdler July 27, 2018 13:27
@ecordell ecordell force-pushed the 1.11-libs branch 2 times, most recently from 0988c0e to 1567974 Compare July 27, 2018 13:33
alecmerdler
alecmerdler previously approved these changes Jul 27, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I definitely may have missed something amongst the 900 files

njhale
njhale previously approved these changes Jul 27, 2018
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alecmerdler
alecmerdler previously approved these changes Jul 28, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I definitely may have missed something amongst the 900 files

ecordell added 14 commits August 1, 2018 10:42
serialization.

In this case, changing to *json.RawMessage fixes the issue
- remove -v1 suffix from ClusterServiceVersion
- makes use of `subresources` for defining statuses
- small fixes to schema
- re-runs codegen for 1.11
- transitionClusterServiceVersion now returns a new object
  - helpers still pass around a mutable copy
- transition only ever updates the status object directly, not the CSV
- switched to structured logging fields where appropriate
- remove -v1 suffix from InstallPlan
- makes use of `subresources` for defining statuses
- small fixes to schema
- re-runs codegen for 1.11
- transitioInstallPlan now returns a new object
  - helpers still pass around a mutable copy
- transition only ever updates the status object directly, not the object
- switched to structured logging fields where appropriate
- updated CRDs to use additionalPrinterColumns and categories
- remove -v1 suffix from ClusterServiceVersion
- makes use of `subresources` for defining statuses
- small fixes to schema
- re-runs codegen for 1.11
- transition only ever updates the status object directly, not the object
- switched to structured logging fields where appropriate
- store the received object from the api instead of the sent object
- remove -v1 suffix from CatalogSource
- makes use of `subresources` for defining statuses
- small fixes to schema
- re-runs codegen for 1.11
@ecordell ecordell force-pushed the 1.11-libs branch 3 times, most recently from 78fe59a to bbed1c9 Compare August 1, 2018 18:52
the newer versions of kubernetes-codegen didn't like the way we had
organized our apis (each type had its own group, but the actual api calls
all went to apps.coreos.com)

this updates the apis to organize around groups/versions instead of
types/versions.

this had fairly wide-reaching effects but ultimately, the codebase is
much simpler for this change.
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be worried about cleaning up leftover resources in these tests?

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Though I may have missed something

@ecordell ecordell merged commit b147e02 into operator-framework:master Aug 2, 2018
@ecordell ecordell deleted the 1.11-libs branch August 7, 2018 14:02
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
chore(deps): update k8s libs to 1.11 versions
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
chore(deps): update k8s libs to 1.11 versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants