Fix e2e Tests #406
Closed
Fix e2e Tests #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves old serviceaccount existance check before replacement CSV creation to avoid race conditions with GC.
Removes a check for unnecessary control loops in TestCreateNewSubscriptionManualApproval. The check was against a fetch of the subscription from immediately after it was created but without waiting for the subscription to reach a desired state. This left room for a race condition which caused sporadic test failures. The check can be removed because TestCreateNewSubscriptionManualApproval is only testing whether newly created subscriptions with installPlanApproval set to manual will create installplans with approval set to manual.
- Adds wait for specific state on fetch of subscriptions - Adds cascading cleanup of test subscriptions - Fixes race conditions on unnecessary control loop checks
- Removes cascading delete option from subscription deletion. - Removes defer cleanup CSV (cleanup subscription will remove CSV(s))
…ests Adds missing deferred cleanup calls to installplan e2e tests. The absence of these calls could cause issues for other tests by leaving the test namespace "messy".
|
merged in #411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes e2e tests failing due to various race conditions.