Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment fixes #418

Merged
merged 7 commits into from
Aug 13, 2018
Merged

Deployment fixes #418

merged 7 commits into from
Aug 13, 2018

Conversation

ecordell
Copy link
Member

  • Updates prometheus operator example
  • Updates roles to explicitly list verbs and resources
  • Updates prometheus operator to not specify securityContext (problems on openshift)

@ecordell ecordell requested review from njhale and alecmerdler August 13, 2018 15:40
alecmerdler
alecmerdler previously approved these changes Aug 13, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecordell ecordell merged commit 2077521 into operator-framework:master Aug 13, 2018
@ecordell ecordell deleted the prom-fixes branch August 14, 2018 13:36
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants