Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Descriptors #426

Merged

Conversation

alecmerdler
Copy link
Member

Description

Adds another type of CRD descriptor (actionDescriptors) which describe certain actions that can be performed on the custom resource as a whole. Examples could be:

  • urn:alm:descriptor:com.tectonic.ui:action:update - shorthand for an app-specific update
  • urn:alm:descriptor:com.tectonic.ui:action:link - external/internal link to a running service

@@ -41,6 +41,15 @@ type SpecDescriptor struct {
Value *json.RawMessage `json:"value,omitempty"`
}

// ActionDescriptor describes a declarative action that can be performed on a custom resource instance
type ActionDescriptor struct {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses the same schema as both SpecDescriptor and StatusDescriptor.

@alecmerdler alecmerdler added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 17, 2018
@alecmerdler alecmerdler requested review from ecordell and njhale August 17, 2018 19:39
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add to the CSV CRD validation block?

Otherwise this looks good! I still think we want to think about splitting this out of the CSV at some point, but for now let's just add these fields here.

Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecmerdler alecmerdler merged commit 5d1c638 into operator-framework:master Aug 17, 2018
@alecmerdler alecmerdler deleted the action-descriptors branch August 17, 2018 23:03
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants