-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action Descriptors #426
Action Descriptors #426
Conversation
@@ -41,6 +41,15 @@ type SpecDescriptor struct { | |||
Value *json.RawMessage `json:"value,omitempty"` | |||
} | |||
|
|||
// ActionDescriptor describes a declarative action that can be performed on a custom resource instance | |||
type ActionDescriptor struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uses the same schema as both SpecDescriptor
and StatusDescriptor
.
2c04f13
to
a7ba5d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add to the CSV CRD validation block?
Otherwise this looks good! I still think we want to think about splitting this out of the CSV at some point, but for now let's just add these fields here.
a7ba5d0
to
e4544e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…criptors Action Descriptors
…criptors Action Descriptors
Description
Adds another type of CRD descriptor (
actionDescriptors
) which describe certain actions that can be performed on the custom resource as a whole. Examples could be:urn:alm:descriptor:com.tectonic.ui:action:update
- shorthand for an app-specific updateurn:alm:descriptor:com.tectonic.ui:action:link
- external/internal link to a running service