Catalog renaming OCS -> rh-operators #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
catalog-rename
branch
2 times, most recently
from
344522f to
eb00936
Compare
sichvoge
requested changes
Aug 23, 2018
There was a problem hiding this comment.
MH. @ecordell You are reverting all changes i've done to the Prometheus CSV back to its original state. The ones from this PR: #425
Also, the final alm-example should look like this:
[{"apiVersion":"monitoring.coreos.com/v1","kind":"Prometheus","metadata":{"name":"example","labels":{"prometheus":"k8s"}},"spec":{"replicas":2,"version":"v2.3.2","serviceAccountName":"prometheus-k8s","securityContext": {}, "serviceMonitorSelector":{"matchExpressions":[{"key":"k8s-app","operator":"Exists"}]},"ruleSelector":{"matchLabels":{"role":"prometheus-rulefiles","prometheus":"k8s"}},"alerting":{"alertmanagers":[{"namespace":"monitoring","name":"alertmanager-main","port":"web"}]}}},{"apiVersion":"monitoring.coreos.com/v1","kind":"ServiceMonitor","metadata":{"name":"example","labels":{"k8s-app":"prometheus"}},"spec":{"selector":{"matchLabels":{"k8s-app":"prometheus"}},"endpoints":[{"port":"web","interval":"30s"}]}},{"apiVersion":"monitoring.coreos.com/v1","kind":"Alertmanager","metadata":{"name":"alertmanager-main"},"spec":{"replicas":3}}]
eb00936 to
fa5d7d7
Compare
also stubs out the "certified-operators" catalog
ecordell
force-pushed
the
catalog-rename
branch
from
fa5d7d7 to
fe79206
Compare
|
@sichvoge Fixed the issues you pointed out |
|
LGTM @alecmerdler Just to confirm, the Console will pick up these changes automatically? |
alecmerdler
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
@ecordell There is one place where we look for the ocs catalog source directly, I will make a PR to fix that.
|
@ecordell Will this be targeting 3.11? |
|
@alecmerdler yes it is, this is in response to @robszumski requests for changes for 3.11 |
njhale
pushed a commit
to njhale/operator-lifecycle-manager
that referenced
this pull request
Sep 10, 2018
Catalog renaming OCS -> rh-operators
ecordell
added a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Catalog renaming OCS -> rh-operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed the
namespaceSelectorfrom the ServiceMonitor example, and removed the edit verbs from the edit aggregated role for OLM