Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Local Console Script with Minikube #441

Merged

Conversation

alecmerdler
Copy link
Member

Description

Need to use --net=host when running against a locally hosted cluster (like minikube or oc cluster up).

Fixes #437

@njhale
Copy link
Member

njhale commented Aug 31, 2018

No longer working on OSX :(

@njhale
Copy link
Member

njhale commented Sep 5, 2018

Hmm, it seems like --net=host doesn't behave the same way on OSX. We could probably make use of the OSTYPE environment variable to do something like:

... 

args="--net=host"
if [[ $OSTYPE == darwin* ]]; then 
  args="-p 9000:9000"
fi

docker run -it $args \
...

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecmerdler alecmerdler merged commit b04c662 into operator-framework:master Sep 5, 2018
@alecmerdler alecmerdler deleted the fix-console-script branch September 5, 2018 16:47
njhale pushed a commit to njhale/operator-lifecycle-manager that referenced this pull request Sep 10, 2018
…e-script

Fix Local Console Script with Minikube
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…e-script

Fix Local Console Script with Minikube
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants