Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(olm): attempt to cleanup namespace annotations on shutdown #453

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

ecordell
Copy link
Member

This is just a best-effort attempt at cleaning up for now. Longer term strategy is to not rely on namespace annotations.

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pending CI

@ecordell
Copy link
Member Author

@ecordell ecordell merged commit b870d91 into operator-framework:master Sep 12, 2018
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really sweet, thanks!

@ecordell ecordell deleted the remove-annotations branch September 21, 2018 12:52
ecordell added a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…tions

feat(olm): attempt to cleanup namespace annotations on shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants