Allow resolving ClusterRoles #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install into olm namespace instead of kube-system
this is parallel to the permissions block, but describes clusterroles and clusterrolebindings the specific placement matches the existing permissions block, which will likely change in the next apiversion
installplan resolution
also refactored some of the InferGVK code to be re-usable in step resolution
openshift-ci-robot
added
the
size/XXL
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
njhale
reviewed
Sep 20, 2018
| @@ -235,7 +234,7 @@ func resolveCRDDescription(sourceRefs []registry.SourceRef, existingCRDOwners ma | |||
| func resolveRBACStepResources(csv *v1alpha1.ClusterServiceVersion) ([]v1alpha1.StepResource, error) { | |||
| var rbacSteps []v1alpha1.StepResource | |||
|
|
|||
| // User a StrategyResolver to | |||
| // User a StrategyResolver to get the strategy details | |||
|
/lgtm |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
Allow resolving ClusterRoles
njhale
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clusterPermissionsto CSV install strategy (just for v1alpha1, we'll revisit for next api version)This greatly expands the power of operators that can be installed with OLM. Restricting what operators can do can be achieved be reducing the scope of permissions given to OLM.
Fixes #477