fix(requirements): add support for non resource url rules #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
njhale
force-pushed
the
non-resource-perms
branch
from
7e79caf to
8c3547d
Compare
njhale
force-pushed
the
non-resource-perms
branch
from
8c3547d to
ad76da4
Compare
|
/assign @alecmerdler |
|
/test e2e-aws |
|
Tested with this patch against olm master and it's working great 👍 |
|
/retest |
ecordell
reviewed
Oct 12, 2018
| @@ -155,3 +163,16 @@ func (c *CSVRuleChecker) hasOwnerConflicts(ownerRefs []metav1.OwnerReference) bo | |||
|
|
|||
| return conflicts | |||
| } | |||
|
|
|||
| func ruleValid(rule rbacv1.PolicyRule) error { | |||
| if len(rule.Verbs) == 0 { | |||
There was a problem hiding this comment.
does the particular openapi flavor kube supports let you specify minItems length on the verb list?
|
/lgtm |
|
/test e2e-aws |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
fix(requirements): add support for non resource url rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: ALM-755 and ALM-756