Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(olm): don't annotate namespaces on operator creation #523

Conversation

ecordell
Copy link
Member

@ecordell ecordell commented Oct 16, 2018

instead let the standard apimachinary take care of calling syncNamespace

There's no need for it, and it fixes OLM startup issues we were seeing on OpenShift 4

instead let the standard apimachinary take care of calling
syncNamespace
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 16, 2018
@ecordell
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@wking
Copy link

wking commented Oct 16, 2018

There's no need for it, and it fixes OLM startup issues we were seeing on OpenShift 4

Is this fixing:

time="2018-10-16T21:43:30Z" level=info msg="Using in-cluster kube client config"
time="2018-10-16T21:43:40Z" level=fatal msg="error configuring operator: namespaces \"openshift-image-registry\" is forbidden: caches not synchronized"

for the olm-operator pod and:

Error: failed to create listener: failed to listen on 0.0.0.0:443: listen tcp 0.0.0.0:443: bind: permission denied

for the package-server pod?

@njhale
Copy link
Member

njhale commented Oct 16, 2018

@wking This looks like a fix for olm-operator. This other PR looks like the fix for package-server.

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2018
@wking
Copy link

wking commented Oct 17, 2018

Looks like it needs a rebase.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2018
@njhale
Copy link
Member

njhale commented Oct 18, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2018
@openshift-merge-robot openshift-merge-robot merged commit 2272906 into operator-framework:master Oct 18, 2018
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
…-immediately

fix(olm): don't annotate namespaces on operator creation
@njhale njhale added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants