Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): cut release 0.7.4 #534

Merged
merged 1 commit into from
Oct 19, 2018
Merged

chore(release): cut release 0.7.4 #534

merged 1 commit into from
Oct 19, 2018

Conversation

njhale
Copy link
Member

@njhale njhale commented Oct 19, 2018

Description

  • Cuts release for 0.7.4
  • Switches from yaml to yq in make release

@njhale
Copy link
Member Author

njhale commented Oct 19, 2018

/approve

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 19, 2018
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018
@jpeeler
Copy link

jpeeler commented Oct 19, 2018

/test e2e-aws

@ecordell
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
ericavonb
ericavonb suggested changes Oct 19, 2018
View reviewed changes
deploy/ocp/manifests/0.7.4/0000_30_13-packageserver.yaml
metadata:
name: v1alpha1.packages.apps.redhat.com
spec:
caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUM5VENDQWQyZ0F3SUJBZ0lCQVRBTkJna3Foa2lHOXcwQkFRc0ZBREFjTVJvd0dBWURWUVFERXhGd1lXTnIKWVdkbExYTmxjblpsY2kxallUQWVGdzB4T0RFd01Ua3hPRFEyTlRaYUZ3MHlPREV3TVRZeE9EUTJOVFphTUJ3eApHakFZQmdOVkJBTVRFWEJoWTJ0aFoyVXRjMlZ5ZG1WeUxXTmhNSUlCSWpBTkJna3Foa2lHOXcwQkFRRUZBQU9DCkFROEFNSUlCQ2dLQ0FRRUF3SmQ5Yk5mdzliMW1PczRncDdlZ0FWKzlFNEgvVUhReDBZSzhoMXFvb2c0eTZWWjIKMVdkUDhLaW5EalJVK0tUamxOazQ4b0Z1aXFKU2VNTmRYS2Y4bUEvK3F6Q2ZFRWt3OEdNMnZLSVB2NkRQeUY0NApBWGhjbVJjMzlFQ0oyU2d0TmxGRU5senhiWFdjQ1ZHRnk4VVJGaVpqdFNJdEpTRTFjVWNnT0dYWGFhVE5ib2Z0Cklvd3FtK0YxWHFEQVhCM1h2c2M2bUkwM0ovZjIvU1AxNC91TVo5SmlaSXg2OCs5OFdPRDhHdmpibWhuSzk5azcKWHdzMm1ZQm04dVR6REZQSjJNd3BPb2xrTEg5ekpjVU9zMVJuV2hvYm5Fek05MGt0NUVPSEdseW9KdGhZTHRWWgovWVlMN2t5YjF4TjlYZ2RKalVOazUwcFhLYlE5RGpQWGczMmwzd0lEQVFBQm8wSXdRREFPQmdOVkhROEJBZjhFCkJBTUNBcVF3SFFZRFZSMGxCQll3RkFZSUt3WUJCUVVIQXdFR0NDc0dBUVVGQndNQ01BOEdBMVVkRXdFQi93UUYKTUFNQkFmOHdEUVlKS29aSWh2Y05BUUVMQlFBRGdnRUJBQnlWVjk5Ris1K0pxcmVoN3VFTjlRMDNZd1QrUnR1MgowYzJqQ0g4REltSHdUVlJhUTNxdzJwd1NUV0VJaEpGT2wvOG1tdkl2VHdoNmM1OGxrNVhYeDl4cHVQc0dtTWtjClFZWkFIZVRSeElWS08renFLUHdSZmdXRzV3WTB6UGNZZUFadU5mbVlzR2NmVHNGK2JFc2FsMXY0S0laQkFNU3QKUlFDaW5jWCtpT1BTK0dEMUtMSGJWUEQrM0RkUUtVeC85cURJSHk2VERCUTJtaVJmN2hFblNWM2dPWlVmWWFvTQptazVuMTRjOG9aMFVOUkVZZHluVmNBL2ZnbGNkcnR2UFp5eE9Ca0tadWxINGhJVDhQTVprcTBuYmxTRlh2anJTCjUwVTlVZ3hsc2tOc3kvbGtLNkJhNFozUEE0d2NPSVphd1psUmtWMmRvcyt3OHVGbnI3Q1BWQlE9Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you add the annotation 'service.alpha.openshift.io/inject-cabundle=true' and let the service-erving-cert-signer-operator inject the caBundle for you: https://github.com/openshift/service-serving-cert-signer/pull/35/files#diff-04c6e90faac2675aa89e2176d2eec7d8R65

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is how this plays out with upstream deployments. Would our manifests ensure the service-serving-cert-signer is instantiated before the package-server? (I understand that with OpenShift and the installer we can ensure existence and ordering)

@openshift-merge-robot openshift-merge-robot merged commit 8b5774b into operator-framework:master Oct 19, 2018
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@openshift-merge-robot
Merge pull request operator-framework#534 from njhale/release-0.7.4
09cdcdb 
chore(release): cut release 0.7.4
@njhale njhale deleted the release-0.7.4 branch September 30, 2019 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericavonb ericavonb ericavonb requested changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@njhale @openshift-ci-robot @jpeeler @ecordell @ericavonb @openshift-merge-robot