Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix olm pod name so log to be written correctly to olm.log #549

Merged

Conversation

dinhxuanvu
Copy link
Member

The olm pod name is incorrect as "alm-operator". It should be
"olm-operator". This issue causes the olm log never being written
into olm.log after the e2e test is run.

Signed-off-by: Vu Dinh vdinh@redhat.com

The olm pod name is incorrect as "alm-operator". It should be
"olm-operator". This issue causes the olm log never being written
into olm.log after the e2e test is run.

Signed-off-by: Vu Dinh <vdinh@redhat.com>
@dinhxuanvu dinhxuanvu requested a review from jpeeler November 2, 2018 18:35
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2018
@dinhxuanvu
Copy link
Member Author

/retest

@ecordell
Copy link
Member

ecordell commented Nov 3, 2018

/approve
/lgtm
/test e2e-aws

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2018
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2018
@ecordell ecordell closed this Nov 3, 2018
@ecordell ecordell reopened this Nov 3, 2018
@ecordell ecordell closed this Nov 3, 2018
@ecordell ecordell reopened this Nov 3, 2018
@ecordell
Copy link
Member

ecordell commented Nov 3, 2018

/test e2e-aws

1 similar comment
@ecordell
Copy link
Member

ecordell commented Nov 3, 2018

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit 99edec4 into operator-framework:master Nov 4, 2018
@dinhxuanvu dinhxuanvu deleted the olm-log-fix branch November 5, 2018 14:13
ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
Fix olm pod name so log to be written correctly to olm.log
@njhale njhale added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants