Operator group follow ups #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2018 20:27
This logging makes it clearer that CRDs are required to be created to pass requirement checks.
openshift-ci-robot
added
the
size/L
ecordell
requested changes
Nov 13, 2018
jpeeler
force-pushed
the
add-operator-group-2
branch
2 times, most recently
from
8f72978 to
bedbea2
Compare
added 2 commits
November 13, 2018 15:33
specifically in this case the resource names must use the plural form
also use waitForDelete instead of writing out more polling code
jpeeler
force-pushed
the
add-operator-group-2
branch
from
bedbea2 to
f233a1a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…roup-2 Operator group follow ups
njhale
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean ups along with the RBAC cluster role creation corrections, specifically with using the plural name for resources.