Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(olm): use cache listers in olm-operator #569

Merged
merged 1 commit into from
Nov 13, 2018
Merged

feat(olm): use cache listers in olm-operator #569

merged 1 commit into from
Nov 13, 2018

Conversation

njhale
Copy link
Member

@njhale njhale commented Nov 13, 2018

Description

Uses cache listers in olm-operator.

Related to: ALM-679

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 13, 2018
alecmerdler
alecmerdler approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2018
@njhale
Copy link
Member Author

njhale commented Nov 13, 2018

/approve

@njhale njhale closed this Nov 13, 2018
@njhale njhale reopened this Nov 13, 2018
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
@njhale njhale merged commit 14aff97 into operator-framework:master Nov 13, 2018
@openshift-ci-robot
Copy link
Collaborator

@njhale: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 1e63998 link /test images
ci/prow/e2e-aws 1e63998 link /test e2e-aws
ci/prow/e2e-aws-olm 1e63998 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ecordell pushed a commit to ecordell/operator-lifecycle-manager that referenced this pull request Mar 8, 2019
@njhale
Merge pull request operator-framework#569 from njhale/caches-for-ever…
0dd31c7 
…yone

feat(olm): use cache listers in olm-operator
@njhale njhale added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2019
@njhale njhale deleted the caches-for-everyone branch September 30, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecmerdler alecmerdler alecmerdler approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@alecmerdler alecmerdler

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njhale @openshift-ci-robot @alecmerdler