Creating csv, crd, and packages for clusterlogging and elasticsearch …

[jcantrill]

…operators

This PR supercedes #555 and includes the code review items

[alecmerdler]

/ok-to-test

[alecmerdler]

Found a couple YAML issues.

[ecordell]

You can run make schema-check locally, which should help you find some of the formatting issues early

Changes addressed

[alecmerdler]

/lgtm

[alecmerdler]

Holding until we can confirm both Operators work out of the box from an OLM Subscription.
/hold

[richm]

Holding until we can confirm both Operators work out of the box from an OLM Subscription.

How do we do that? If I have a running cluster with olm, something like this?

• oc edit -n operator-lifecycle-manager cm/rh-operators
• add the logging package definitions to packages
• add the logging crds to customResourceDefinitions
• add the logging csvs to clusterServiceVersions
  ?

[jcantrill]

Holding until we can confirm both Operators work out of the box from an OLM Subscription.

How do we do that? If I have a running cluster with olm, something like this?

• oc edit -n operator-lifecycle-manager cm/rh-operators
• add the logging package definitions to packages
• add the logging crds to customResourceDefinitions
• add the logging csvs to clusterServiceVersions
  ?

Not sure if it is functional yet on the cluster but with @ecordell help I was able to deploy and display in the console:

$ oc scale -nopenshift-cluster-version --replicas=0 rs cluster-version-operator-7c5757d89
$ make release
...
wrote /tmp/tmp.u3y4Vk7V1f/chart/olm/templates/0000_30_06-rh-operators.configmap.yaml
...
$ oc replace --force -f /tmp/tmp.ivzg0towEf/chart/olm/templates/0000_30_06-rh-operators.configmap.yaml

Wait for a few minutes...

$ oc get packagemanifest
NAME                   AGE
svcat                  4h
couchbase-enterprise   4h
etcd                   4h
federationv2           4h
prometheus             4h
descheduler            8m
elasticsearch          8m
dynatrace-monitoring   4h
mongodb-enterprise     4h
amq-streams            4h
clusterLogging         8m

[jcantrill]

@alecmerdler @ecordell I have successfully deployed my operators though not logging (unrelated to OLM). I'm satisfied this PR provides the opportunity to deploy cluster-logging. It works assuming the image defined in the package manifest can be pulled which I assume will be resolved by the release process. Only things I'm not sure if they are addressable by what changes we make here:

• elasticsearch-operator should not be visible in the UI; there is no intention to allow users to deploy the EO without CLO
• Deleting the CLO subscription does not appear to remove the EO clusterserviceversion or affiliated service, deployment, replicaset, pod. Should it?
• Not sure how the failed jobs relate to these changes.

[alecmerdler]

1. Even if we use filter in the UI, the PackageManifest will still be visible using kubectl and creating a Subscription for the elasticsearch-operator will result in OLM deploying the Operator. It sounds like you should make 2 CSVs for the CLO: one that includes the elasticsearch-operator deployment and CRD, and one without.
2. No, it should not.
3. IDK either, OpenShift CI is a mystery to me

[ecordell]

@jcantrill the e2e test is a flake (the installer failed to bring up the cluster). if you rebase, I would expect to see the unit test job pass, though

[jcantrill]

The most recent push combines the operators into a single deployment for now. Rebased as well. cc @alecmerdler. Tested PR directly and functions as I would expect when the proper images are in the packages

[ewolinetz]

openshift/cluster-logging-operator#55 removes our operator's prior dependency on a signer cert (privileged operation) being provided to us.

[ecordell]

#617 merged and fixes make schema-check to actually be checking your manifests

[ecordell]

/approve
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ecordell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment